test: fix flaky TestWaitBlockExecutingCommand using Eventually#3373
Open
ShanukaGallage wants to merge 1 commit intoapache:unstablefrom
Open
test: fix flaky TestWaitBlockExecutingCommand using Eventually#3373ShanukaGallage wants to merge 1 commit intoapache:unstablefrom
ShanukaGallage wants to merge 1 commit intoapache:unstablefrom
Conversation
ShanukaGallage
changed the title
ShanukaGallage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the flaky test
TestWaitBlockExecutingCommandinwait_test.go(Fixes #3157).The Issue:
The test previously used
time.Sleep(1 * time.Second)to wait for the server to block the client. This caused flakes on slower/faster machines where the sleep duration was insufficient or excessive.The Fix:
Replaced
time.Sleepwithrequire.Eventually. The test now explicitly checks the server'sclientsinfo forblocked_clients:1before proceeding. This makes the test deterministic and faster.Verification:
Run
go test -v ./unit/wait/locally -> PASSED.