feat(tdigest): implement TDIGEST.TRIMMED_MEAN command#3312
Open
chakkk309 wants to merge 5 commits intoapache:unstablefrom
Open
feat(tdigest): implement TDIGEST.TRIMMED_MEAN command#3312chakkk309 wants to merge 5 commits intoapache:unstablefrom
chakkk309 wants to merge 5 commits intoapache:unstablefrom
Conversation
# Conflicts: # src/types/redis_tdigest.h # src/types/tdigest.h
LindaSummer
reviewed
Dec 27, 2025
Member
LindaSummer
left a comment
LindaSummer
left a comment
There was a problem hiding this comment.
Hi @chakkk309 ,
😊 It seems this commit couldn't pass the ci. Please help check the error message in github actions.
src/types/redis_tdigest.cc
Outdated
| if (auto status = dumpCentroids(ctx, ns_key, metadata, ¢roids); !status.ok()) { | ||
| return status; | ||
| } | ||
| auto dump_centroids = DummyCentroids(metadata, centroids); |
Member
There was a problem hiding this comment.
Hi @chakkk309 ,
It seems that this line has compile error in CI. Please make a check.
Member
|
Hi, thank you for your contribution! Before you start coding, could you please read our contribution guide (https://kvrocks.apache.org/community/contributing/)? It can be better if you build and test Kvrocks against your changes successfully in your local before pushing them. Also note that we have guidelines for AI-assisted contributions: https://kvrocks.apache.org/community/contributing/#guidelines-for-ai-assisted-contributions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3066