Skip to content

KAFKA-20194: Ensure backward compatibility for Sliding Windows#21949

Merged
mjsax merged 2 commits intoapache:trunkfrom
mjsax:kafka-20194-ensure-backward-compatiblity-sliding
Apr 6, 2026
Merged

KAFKA-20194: Ensure backward compatibility for Sliding Windows#21949
mjsax merged 2 commits intoapache:trunkfrom
mjsax:kafka-20194-ensure-backward-compatiblity-sliding

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Apr 3, 2026

By default, the DSL should expose it's state-stores as ts-stores, as
long as header format is not enabled; otherwise, it would be a backward
incompatible change.

This PR ensures that the builders are creating the correct state stores,
depending on the format, and we insert an adaptor to allow the DSL
Processors to work only against headers-store interface.

Reviewers: Bill Bejeck bbejeck@apache.org

@mjsax mjsax added streams kip Requires or implements a KIP labels Apr 3, 2026
mjsax added 2 commits April 3, 2026 12:55
By default, the DSL should expose it's state-stores as ts-stores, as
long as header format is not enabled; otherwise, it would be a backward
incompatible change.

This PR ensures that the builders are creating the correct state stores,
depending on the format, and we insert an adaptor to allow the DSL
Processors to work only against headers-store interface.
@mjsax mjsax force-pushed the kafka-20194-ensure-backward-compatiblity-sliding branch from 2f79032 to 9589f25 Compare April 3, 2026 19:57
Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax mjsax merged commit 7b8549f into apache:trunk Apr 6, 2026
22 checks passed
@mjsax mjsax deleted the kafka-20194-ensure-backward-compatiblity-sliding branch April 6, 2026 22:06
mjsax added a commit that referenced this pull request Apr 6, 2026
By default, the DSL should expose it's state-stores as ts-stores, as
long as header format is not enabled; otherwise, it would be a backward
incompatible change.

This PR ensures that the builders are creating the correct state stores,
depending on the format, and we insert an adaptor to allow the DSL
Processors to work only against headers-store interface.

Reviewers: Bill Bejeck <bbejeck@apache.org>
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Apr 6, 2026

Merged to trunk and cherry-picked to 4.3 branch.

nileshkumar3 pushed a commit to nileshkumar3/kafka that referenced this pull request Apr 15, 2026
…e#21949)

By default, the DSL should expose it's state-stores as ts-stores, as
long as header format is not enabled; otherwise, it would be a backward
incompatible change.

This PR ensures that the builders are creating the correct state stores,
depending on the format, and we insert an adaptor to allow the DSL
Processors to work only against headers-store interface.

Reviewers: Bill Bejeck <bbejeck@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kip Requires or implements a KIP streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants