IGNITE-28532 Introduce JUnit Rolling Upgrade Testing Framework#13108
Open
maksaska wants to merge 5 commits into
Open
IGNITE-28532 Introduce JUnit Rolling Upgrade Testing Framework#13108maksaska wants to merge 5 commits into
maksaska wants to merge 5 commits into
Conversation
Vladsz83
reviewed
May 21, 2026
| import org.apache.ignite.SystemProperty; | ||
| import org.apache.ignite.internal.util.typedef.X; | ||
|
|
||
| /** */ |
Contributor
There was a problem hiding this comment.
Let's describe what it does.
|
|
||
| /** */ | ||
| public class DistributionProvider { | ||
| /** Base Ignite distribution location */ |
| private static final String DEFAULT_TARGET_REL_PATH = "target/release-package-apache-ignite"; | ||
|
|
||
| /** */ | ||
| private static final String LATEST_VERSION = "2.18.0"; |
Contributor
There was a problem hiding this comment.
Is there any automation? Do we need to fix this version at each release?
Contributor
Author
There was a problem hiding this comment.
I don't think there is. We will have to track the latest RU compatible release like we do for the rest compatibility tests.
| public static File resolveTargetDist() { | ||
| String explicit = IgniteSystemProperties.getString(TARGET_DIST); | ||
|
|
||
| if (explicit != null && !explicit.isEmpty()) |
| } | ||
|
|
||
| throw new IllegalStateException( | ||
| "Target distribution not found. " + |
Contributor
There was a problem hiding this comment.
No chance for single line?
| /** {@inheritDoc} */ | ||
| @Override protected void afterTest() throws Exception { | ||
| for (int i : gridProxies.keySet()) | ||
| stopNode(i); |
Contributor
There was a problem hiding this comment.
Will it coninue if curent node failed for some reason?
| } | ||
|
|
||
| /** | ||
| * Centralized logic for node lifecycle. |
Contributor
There was a problem hiding this comment.
Looks like it doesn't stop a node. So, it is not a lifecycle. Let's simplify, smth. like 'starts or restarts node with required version'
| /** | ||
| * Resolves a specific directory for a node index and ensures it exists. | ||
| */ | ||
| private String resolveDir(String root, int idx) { |
| /** | ||
| * Deletes the entire root directory and all subdirectories/files. | ||
| */ | ||
| private void deleteRootDir(String root) throws IOException { |
Contributor
There was a problem hiding this comment.
Static? Can we use U#delete()?
| /** | ||
| * Builds a classpath string based on the provided Ignite home directory. | ||
| * | ||
| * @param igniteHome The root directory of the Ignite distribution. |
Vladsz83
reviewed
May 21, 2026
| /** | ||
| * Task to update the cluster state. | ||
| */ | ||
| private static class StateTask extends ClusterTaskAdapter<Void> { |
Contributor
There was a problem hiding this comment.
Do we need a task for typical API feature? We can change the state with thin client as instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.