Skip to content

IGNITE-28331 Fix SQL search by _key for a composite pk in Calcite engine #12926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkalkirill merged 34 commits into from
Apr 7, 2026

IGNITE-28331 after review aplekhanov #3.1

1394650
Select commit
Loading
Failed to load commit list.
Merged

IGNITE-28331 Fix SQL search by _key for a composite pk in Calcite engine #12926

IGNITE-28331 after review aplekhanov #3.1
1394650
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 6, 2026 in 2m 3s

Quality Gate failed

Failed conditions
19 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1175 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1W7Qzof2jVVBs5LlnI&open=AZ1W7Qzof2jVVBs5LlnI&pullRequest=12926

Check warning on line 190 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1JYlMdYdYQfzI5THQH&open=AZ1JYlMdYdYQfzI5THQH&pullRequest=12926

Check warning on line 226 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this assert with a proper check. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ0tgSMgJp73I62kfljR&open=AZ0tgSMgJp73I62kfljR&pullRequest=12926

Check warning on line 82 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheWrappedKeyIndexImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1JYlMAYdYQfzI5THQG&open=AZ1JYlMAYdYQfzI5THQG&pullRequest=12926

Check warning on line 1128 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1W7Qzof2jVVBs5LlnF&open=AZ1W7Qzof2jVVBs5LlnF&pullRequest=12926

Check warning on line 272 in modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ0aycksufp2jxPAeb11&open=AZ0aycksufp2jxPAeb11&pullRequest=12926

Check warning on line 85 in modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1U7Tzxhf7x-hm_deVc&open=AZ1U7Tzxhf7x-hm_deVc&pullRequest=12926

Check warning on line 318 in modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1O3EQHwNIGB3Ttl3VX&open=AZ1O3EQHwNIGB3Ttl3VX&pullRequest=12926

Check warning on line 1162 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1W7Qzof2jVVBs5LlnH&open=AZ1W7Qzof2jVVBs5LlnH&pullRequest=12926

Check warning on line 547 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/Commons.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1Mj6uKqMxKRhSA94A2&open=AZ1Mj6uKqMxKRhSA94A2&pullRequest=12926

Check warning on line 64 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheWrappedKeyIndexImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1JYlMAYdYQfzI5THQF&open=AZ1JYlMAYdYQfzI5THQF&pullRequest=12926

Check warning on line 207 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this assert with a proper check. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ0tgSMgJp73I62kfljQ&open=AZ0tgSMgJp73I62kfljQ&pullRequest=12926

Check warning on line 303 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this assert with a proper check. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ0pC2pDHCNUh2gxAKqq&open=AZ0pC2pDHCNUh2gxAKqq&pullRequest=12926

Check warning on line 208 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1JYlMdYdYQfzI5THQI&open=AZ1JYlMdYdYQfzI5THQI&pullRequest=12926

Check warning on line 214 in modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ0aycksufp2jxPAeb10&open=AZ0aycksufp2jxPAeb10&pullRequest=12926

Check warning on line 1161 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1W7Qzof2jVVBs5LlnG&open=AZ1W7Qzof2jVVBs5LlnG&pullRequest=12926

Check warning on line 42 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexWrappedKeyScan.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1JYlFWYdYQfzI5THQB&open=AZ1JYlFWYdYQfzI5THQB&pullRequest=12926

Check warning on line 181 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "collation" which hides the field declared at line 53. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1TU3ToV80h1QdmokWm&open=AZ1TU3ToV80h1QdmokWm&pullRequest=12926

Check warning on line 1176 in modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=apache_ignite&issues=AZ1W7Qzof2jVVBs5LlnJ&open=AZ1W7Qzof2jVVBs5LlnJ&pullRequest=12926
View more details on SonarQubeCloud