Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/compute/jobs.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ dependencies {
jobsImplementation project(':ignite-transactions')
jobsImplementation project(':ignite-runner')
jobsImplementation testFixtures(project(':ignite-runner'))
jobsCompileOnly libs.spotbugs.annotations
unit1Implementation project(':ignite-api')
unit2Implementation project(':ignite-api')
}
Original file line number Diff line number Diff line change
Expand Up @@ -906,11 +906,11 @@ public void observableTsIsPropagatedToTargetNode() {
ObservableTimestampResult jobRes = execution.resultAsync().join();

// The per-job tracker should have the client's observable timestamp.
HybridTimestamp jobObservableTs = HybridTimestamp.nullableHybridTimestamp(jobRes.perJobTimestamp);
HybridTimestamp jobObservableTs = HybridTimestamp.nullableHybridTimestamp(jobRes.perJobTimestamp());
assertThat(jobObservableTs, is(localObservableTs));

// The node's global tracker should NOT be updated by the compute job.
HybridTimestamp targetNodeTsAfter = HybridTimestamp.nullableHybridTimestamp(jobRes.nodeGlobalTimestamp);
HybridTimestamp targetNodeTsAfter = HybridTimestamp.nullableHybridTimestamp(jobRes.nodeGlobalTimestamp());
assertThat(targetNodeTsAfter, is(targetNodeTsBefore));
assertThat(targetNodeTsAfter, not(jobObservableTs));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
* Result of {@link ObservableTimestampJob} containing both per-job and node global observable timestamps.
*/
public class ObservableTimestampResult {
public long perJobTimestamp;
public long nodeGlobalTimestamp;
private long perJobTimestamp;
private long nodeGlobalTimestamp;

public ObservableTimestampResult() {
}
Expand All @@ -31,4 +31,12 @@ public ObservableTimestampResult(long perJobTimestamp, long nodeGlobalTimestamp)
this.perJobTimestamp = perJobTimestamp;
this.nodeGlobalTimestamp = nodeGlobalTimestamp;
}

public long perJobTimestamp() {
return perJobTimestamp;
}

public long nodeGlobalTimestamp() {
return nodeGlobalTimestamp;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,12 @@

package org.example.jobs.standalone;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

/**
* Result of {@link ObservableTimestampJob} containing both per-job and node global observable timestamps.
*/
@SuppressFBWarnings(
value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD",
justification = "Fields are read in integration tests via deserialized object"
)
public class ObservableTimestampResult {
public long perJobTimestamp;
public long nodeGlobalTimestamp;
private long perJobTimestamp;
private long nodeGlobalTimestamp;

public ObservableTimestampResult() {
}
Expand All @@ -37,4 +31,12 @@ public ObservableTimestampResult(long perJobTimestamp, long nodeGlobalTimestamp)
this.perJobTimestamp = perJobTimestamp;
this.nodeGlobalTimestamp = nodeGlobalTimestamp;
}

public long perJobTimestamp() {
return perJobTimestamp;
}

public long nodeGlobalTimestamp() {
return nodeGlobalTimestamp;
}
}