IGNITE-27303 C++ 3.0: [ODBC] Use distribution packages to run ODBC tests #7516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcolight
force-pushed
the
ignite-27303
branch
from
3cd039d to
66691a7
Compare
arcolight
force-pushed
the
ignite-27303
branch
from
839d995 to
f1f0728
Compare
Artyeshi
approved these changes
Feb 11, 2026
Erixonich
approved these changes
Feb 11, 2026
isapego
requested changes
Feb 12, 2026
| import org.apache.ignite.teamcity.CustomBuildSteps.Companion.customScript | ||
|
|
||
| object ClientPackages : BuildType({ | ||
| name = "[11] ODBC and Client packages" |
Contributor
There was a problem hiding this comment.
Suggested change
| name = "[11] ODBC and Client packages" | |
| name = "[11] ODBC and C++ Client packages" |
| import jetbrains.buildServer.configs.kotlin.buildSteps.script | ||
| import org.apache.ignite.teamcity.CustomBuildSteps.Companion.customScript | ||
|
|
||
| object ClientPackages : BuildType({ |
Contributor
There was a problem hiding this comment.
Let's make sure to not confuse people - we have a lot of different clients, but this suite is only about C++ ones.
Suggested change
| object ClientPackages : BuildType({ | |
| object CppClientPackages : BuildType({ |
Contributor
Author
There was a problem hiding this comment.
Ok, I agree. Renamed.
| mkdir %PATH__CMAKE_BUILD_DIRECTORY% || exit 2 | ||
| cd %PATH__CMAKE_BUILD_DIRECTORY% || exit 3 | ||
|
|
||
| cmake .. -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DENABLE_TESTS=ON -DENABLE_ODBC=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=%env.CPP_STAGING% || (echo 'CMake configuration failed' && exit 5) |
Contributor
There was a problem hiding this comment.
Let's disable client compilation - it will reduce building time.
Suggested change
| cmake .. -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DENABLE_TESTS=ON -DENABLE_ODBC=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=%env.CPP_STAGING% || (echo 'CMake configuration failed' && exit 5) | |
| cmake .. -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DENABLE_TESTS=ON -DENABLE_ODBC=ON -DENABLE_CLIENT=OFF -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=%env.CPP_STAGING% || (echo 'CMake configuration failed' && exit 5) |
Contributor
Author
There was a problem hiding this comment.
Hmm, it does not work. For odbc-test we need ignite3-client-static.
modules/platforms/cpp/_version.txt
Outdated
| @@ -1 +1 @@ | |||
| 3.2.0 No newline at end of file | |||
| 3.2.0.9999 No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I see that file is changed, but the function updateCMakeVersion in build.gradle, which generates it didn't. Should we update it accordingly?
Contributor
Author
There was a problem hiding this comment.
Ok, I reverted it back. Parsing algorithm updated to handle simple version as well.
added 24 commits
February 13, 2026 07:16
added 18 commits
February 13, 2026 07:16
This reverts commit 97e01de.
arcolight
force-pushed
the
ignite-27303
branch
from
0341c2a to
731fc55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27303
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes