[IGNORE ME]fix(docs): add hwloc and pkg-config installation prerequisites by OS#3143
Open
Standing-Man wants to merge 6 commits intoapache:masterfrom
Open
[IGNORE ME]fix(docs): add hwloc and pkg-config installation prerequisites by OS#3143Standing-Man wants to merge 6 commits intoapache:masterfrom
hwloc and pkg-config installation prerequisites by OS#3143Standing-Man wants to merge 6 commits intoapache:masterfrom
Conversation
Signed-off-by: StandingMan <jmtangcs@gmail.com>
hwloc and pkg-config installation prerequisites by OShwloc and pkg-config installation prerequisites by OS
hwloc and pkg-config installation prerequisites by OShwloc and pkg-config installation prerequisites by OS
Contributor
Author
mmodzelewski
approved these changes
Apr 23, 2026
Contributor
Author
|
Hi, Please hold off on merging this PR for now. I think |
hwloc and pkg-config installation prerequisites by OShwloc and pkg-config installation prerequisites by OS
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale
Local builds are prone to failure due to undocumented prerequisites:
hwlocalitydepends on systemhwloc, and detection relies onpkg-config/pkgconf, which are not currently documented inCONTRIBUTING.md.What changed?
Updated
CONTRIBUTING.mdby adding a new System Dependencies section under Run It Locally that:hwlocality(hwlocbindings).non-musltargets need systemhwloc devpackages before build.Ubuntu/Debian:libhwloc-dev pkg-configFedora/RHEL/CentOS:hwloc-devel pkgconf-pkg-configArch:hwloc pkgconfmacOS (Homebrew):hwloc pkg-configmusltargets use vendoredhwlocalitysupport in this repo.Local Execution
Passed
Ran
AI Usage