Skip to content

refactor(go): upgrade go-retry to v5 and enable infinite reconnection#2884

Open
chengxilo wants to merge 4 commits intoapache:masterfrom
chengxilo:go-retry-upgrade
Open

refactor(go): upgrade go-retry to v5 and enable infinite reconnection#2884
chengxilo wants to merge 4 commits intoapache:masterfrom
chengxilo:go-retry-upgrade

Conversation

@chengxilo
Copy link
Contributor

Which issue does this PR close?

N/A

Rationale

Upgrade retry-go to v5, since I just realized that v3 will crash when the WithAttempts() receive a big uint value, e.g. math.MaxUint32.

Also, to align with the rust client behavior, go sdk should have infinite retry for reconnection.

What changed?

  1. retry-go version upgrade to v5.
  2. Default attempts set to 0, which means infinite for go-retry

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

None

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.33%. Comparing base (ecd7709) to head (408b0fe).

Files with missing lines Patch % Lines
foreign/go/client/tcp/tcp_core.go 0.00% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2884      +/-   ##
============================================
- Coverage     68.36%   68.33%   -0.03%     
  Complexity      739      739              
============================================
  Files          1053     1052       -1     
  Lines         84763    84749      -14     
  Branches      61297    61278      -19     
============================================
- Hits          57948    57914      -34     
- Misses        24448    24465      +17     
- Partials       2367     2370       +3     
Flag Coverage Δ
go 6.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
foreign/go/client/tcp/tcp_core.go 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mmodzelewski
mmodzelewski previously approved these changes Mar 6, 2026
Copy link
Contributor

@atharvalade atharvalade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants