refactor(go): upgrade go-retry to v5 and enable infinite reconnection#2884
Open
chengxilo wants to merge 4 commits intoapache:masterfrom
Open
refactor(go): upgrade go-retry to v5 and enable infinite reconnection#2884chengxilo wants to merge 4 commits intoapache:masterfrom
chengxilo wants to merge 4 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2884 +/- ##
============================================
- Coverage 68.36% 68.33% -0.03%
Complexity 739 739
============================================
Files 1053 1052 -1
Lines 84763 84749 -14
Branches 61297 61278 -19
============================================
- Hits 57948 57914 -34
- Misses 24448 24465 +17
- Partials 2367 2370 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mmodzelewski
previously approved these changes
Mar 6, 2026
atharvalade
suggested changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale
Upgrade retry-go to v5, since I just realized that v3 will crash when the WithAttempts() receive a big uint value, e.g.
math.MaxUint32.Also, to align with the rust client behavior, go sdk should have infinite retry for reconnection.
What changed?
go-retryLocal Execution
AI Usage
None