chore(consensus): enable pedantic and nursery clippy lints

[hubcio]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 58.33333% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.31%. Comparing base (185215f) to head (9dc3161).

Files with missing lines	Patch %	Lines
core/consensus/src/impls.rs	62.50%	12 Missing ⚠️
core/consensus/src/vsr_timeout.rs	68.75%	5 Missing ⚠️
core/consensus/src/view_change_quorum.rs	33.33%	4 Missing ⚠️
core/consensus/src/plane_mux.rs	0.00%	3 Missing ⚠️
core/consensus/src/plane_helpers.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2870      +/-   ##
============================================
- Coverage     68.31%   68.31%   -0.01%     
  Complexity      739      739              
============================================
  Files          1052     1052              
  Lines         84745    84744       -1     
  Branches      61277    61276       -1     
============================================
- Hits          57892    57891       -1     
- Misses        24481    24482       +1     
+ Partials       2372     2371       -1     

Flag	Coverage Δ
rust	70.01% <58.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
core/consensus/src/namespaced_pipeline.rs	97.20% <100.00%> (ø)
core/consensus/src/plane_helpers.rs	56.56% <50.00%> (ø)
core/consensus/src/plane_mux.rs	0.00% <0.00%> (ø)
core/consensus/src/view_change_quorum.rs	71.11% <33.33%> (+4.44%)	⬆️
core/consensus/src/vsr_timeout.rs	72.89% <68.75%> (+0.33%)	⬆️
core/consensus/src/impls.rs	42.48% <62.50%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[atharvalade]

arent nursery lints explicitly unstable? clippy may rename, remove, or introduce false positives for them between releases. With "deny", any such upstream change becomes a hard build failure the next time the toolchain is bumped past 1.93.0.

why dont you consider using "warn" here instead; you get the same enforcement by failing on warnings in CI, without the risk of a toolchain update unexpectedly breaking the consensus crate. I see core/bench already does the same, so it might be worth revisiting that one too.