feat(java): implement Async Connection Pooling using FixedChannelPool by rythm-sachdeva · Pull Request #2606 · apache/iggy

rythm-sachdeva · 2026-01-24T09:23:48Z

Description

Implements connection pooling for AsyncTcpConnection using Netty's FixedChannelPool to handle concurrent async operations efficiently.

Changes

Connection Pooling: Replaced single channel with FixedChannelPool for concurrent request handling
Pool Metrics: Added PoolMetrics class to track:
- Active connections
- Total requests and errors
- Wait times (min/max/average in nanoseconds, microseconds, and milliseconds)
- Error rate percentage
Configuration: Added TCPConnectionPoolConfig with builder pattern for customizing:
- Max connections (default: 5)
- Max pending acquires (default: 1000)
- Acquire timeout (default: 3000ms)
Request Correlation: Implemented FIFO queue-based request/response matching using ConcurrentLinkedQueue
Broadcast Operations: Added broadcastAsync() method to execute commands across all pooled connections (useful for authentication)
Client Integration: Exposed pool configuration via AsyncIggyTcpClient.Builder.connectionPoolSize()

Implementation Details

Uses Netty's FixedChannelPool with ChannelHealthChecker.ACTIVE
Each channel has its own IggyResponseHandler with a response queue
Pool automatically releases channels after request completion
Handles connection errors gracefully with proper cleanup

Testing

Added integration test testConnectionPoolMetrics() to verify metrics tracking
Existing async integration tests validate concurrent operations
Pool properly handles concurrent sends and polls

github-actions · 2026-02-04T00:34:55Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.

Thank you for your contribution!

rythm-sachdeva · 2026-02-09T14:21:08Z

Hi @mmodzelewski Can you please review .

mmodzelewski · 2026-02-09T21:20:40Z

Hi @mmodzelewski Can you please review .

Hey @rythm-sachdeva, I will, but I need some time. I might not get round to it until the beginning of next week.

slbotbm · 2026-02-17T17:46:03Z

@rythm-sachdeva Please see why CI is failing and fix the errors.

mmodzelewski · 2026-02-17T18:17:26Z

@rythm-sachdeva Please see why CI is failing and fix the errors.

@rythm-sachdeva I've added a verification if all ByteBufs are properly released (not leaked) and it appears that the new code does not release all resources. See the logs, or run the tests locally, you'll see reports of the leaks in there.

codecov · 2026-02-22T08:58:29Z

Codecov Report

❌ Patch coverage is 62.18905% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.11%. Comparing base (ae29f6c) to head (3cdbc18).
⚠️ Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
...ache/iggy/client/async/tcp/AsyncTcpConnection.java	63.19%	37 Missing and 16 partials ⚠️
...apache/iggy/client/async/tcp/IggyFrameEncoder.java	45.00%	10 Missing and 1 partial ⚠️
...gy/client/async/tcp/AsyncIggyTcpClientBuilder.java	0.00%	4 Missing and 2 partials ⚠️
...pache/iggy/client/async/tcp/IggyAuthenticator.java	76.00%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2606      +/-   ##
============================================
- Coverage     70.27%   68.11%   -2.16%     
- Complexity      739      763      +24     
============================================
  Files          1038     1052      +14     
  Lines         85756    84021    -1735     
  Branches      62144    60635    -1509     
============================================
- Hits          60263    57230    -3033     
- Misses        22992    24420    +1428     
+ Partials       2501     2371     -130

Flag	Coverage Δ
java	`55.15% <62.18%> (+0.32%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ache/iggy/client/async/tcp/AsyncIggyTcpClient.java	`98.48% <100.00%> (+0.09%)`	⬆️
...gy/client/async/tcp/AsyncIggyTcpClientBuilder.java	`77.27% <0.00%> (-12.21%)`	⬇️
...pache/iggy/client/async/tcp/IggyAuthenticator.java	`76.00% <76.00%> (ø)`
...apache/iggy/client/async/tcp/IggyFrameEncoder.java	`45.00% <45.00%> (ø)`
...ache/iggy/client/async/tcp/AsyncTcpConnection.java	`65.36% <63.19%> (+2.86%)`	⬆️

... and 141 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mmodzelewski

Hey @rythm-sachdeva, I left a few comments, please let me know if you have any questions.

mmodzelewski · 2026-03-02T08:29:09Z

Hi @rythm-sachdeva, please run tests/lints before pushing out the changes.

rythm-sachdeva · 2026-03-02T08:56:57Z

Hi @rythm-sachdeva, please run tests/lints before pushing out the changes.

Sorry, will surely do it next time.

mmodzelewski · 2026-03-03T11:01:39Z

@rythm-sachdeva please ping me when the PR is ready for review.

rythm-sachdeva · 2026-03-04T23:16:06Z

Hi @mmodzelewski can you check once I have updated the pr

mmodzelewski · 2026-03-05T07:44:22Z

@rythm-sachdeva please fix the lints. I see that there's IllegalStateException in the code instead of Iggy's equivalent. Also, any commented out code should be removed.
And please remove PoolMetrics as I asked in the comment above.

rythm-sachdeva · 2026-03-05T08:43:31Z

Sure @mmodzelewski will do that.

rythm-sachdeva · 2026-03-06T14:57:49Z

Hi @mmodzelewski can you review once.

fix(java-sdk):Added Missing PoolMetrics and linting issues fix(java):fixed connection error fix(java):Fixed Linting Issues fix(java):fixed builder issues fix(java):fixed ci issues fix(java): fixed memory leaks fix(java):fixed memory leak at channelread0 fix(java):fixed broadcastasync memory leak feat(java): Added attribute based channel login fix(java): fixed error handling in inbound handler fix(java):Fixed login issues fix(java): Fixed connection pool login logout bugs fix(java): fixed authentication bugs fix(java): fixed checkStyle Errors

rythm-sachdeva · 2026-03-07T03:16:45Z

Hi @mmodzelewski Can you please re run the workflow I have fixed check style errors

ex172000 reviewed Jan 27, 2026

View reviewed changes

mmodzelewski linked an issue Jan 27, 2026 that may be closed by this pull request

[Java SDK] Implement Connection Pooling for Async Client #2232

Closed

20 tasks

github-actions Bot added the stale Inactive issue or pull request label Feb 4, 2026

hubcio changed the title ~~feat(java): Implemented Async Connection Pooling using FixedChannelPool (#2232)~~ feat(java): implement Async Connection Pooling using FixedChannelPool Feb 4, 2026

github-actions Bot removed the stale Inactive issue or pull request label Feb 5, 2026

rythm-sachdeva force-pushed the feature/async-connection-pool branch 2 times, most recently from 2cdb131 to 50e8a36 Compare February 7, 2026 06:56

rythm-sachdeva force-pushed the feature/async-connection-pool branch from 50e8a36 to ca4583f Compare February 17, 2026 15:08

rythm-sachdeva force-pushed the feature/async-connection-pool branch 4 times, most recently from 4eaf354 to 181682b Compare February 22, 2026 01:40

mmodzelewski requested changes Feb 24, 2026

View reviewed changes

mmodzelewski reviewed Feb 24, 2026

View reviewed changes

Comment thread foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncTcpConnection.java

rythm-sachdeva force-pushed the feature/async-connection-pool branch from 181682b to a31643a Compare February 28, 2026 13:48

rythm-sachdeva force-pushed the feature/async-connection-pool branch from a31643a to 1c86e1a Compare March 4, 2026 04:32

rythm-sachdeva force-pushed the feature/async-connection-pool branch 2 times, most recently from 499dca0 to 6e2ba9f Compare March 6, 2026 14:54

rythm-sachdeva force-pushed the feature/async-connection-pool branch from 6e2ba9f to 4670a84 Compare March 7, 2026 03:15

Merge branch 'master' into feature/async-connection-pool

9bedd38

mmodzelewski approved these changes Mar 9, 2026

View reviewed changes

Merge branch 'master' into feature/async-connection-pool

3cdbc18

hubcio approved these changes Mar 9, 2026

View reviewed changes

mmodzelewski merged commit 7d20f31 into apache:master Mar 9, 2026
33 checks passed

Conversation

rythm-sachdeva commented Jan 24, 2026

Description

Changes

Implementation Details

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

rythm-sachdeva commented Feb 9, 2026

Uh oh!

mmodzelewski commented Feb 9, 2026

Uh oh!

slbotbm commented Feb 17, 2026

Uh oh!

mmodzelewski commented Feb 17, 2026

Uh oh!

codecov Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mmodzelewski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmodzelewski commented Mar 2, 2026

Uh oh!

rythm-sachdeva commented Mar 2, 2026

Uh oh!

mmodzelewski commented Mar 3, 2026

Uh oh!

rythm-sachdeva commented Mar 4, 2026

Uh oh!

mmodzelewski commented Mar 5, 2026

Uh oh!

rythm-sachdeva commented Mar 5, 2026

Uh oh!

rythm-sachdeva commented Mar 6, 2026

Uh oh!

rythm-sachdeva commented Mar 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Feb 22, 2026 •

edited

Loading