REST: Explicitly send purgeRequested=false when dropping table without purge#15164
Closed
hackintoshrao wants to merge 1 commit intoapache:mainfrom
Closed
REST: Explicitly send purgeRequested=false when dropping table without purge#15164hackintoshrao wants to merge 1 commit intoapache:mainfrom
hackintoshrao wants to merge 1 commit intoapache:mainfrom
Conversation
…t purge The REST catalog client previously omitted the purgeRequested parameter when calling dropTable with purge=false. This relied on the server defaulting to purge=false. However, some catalogs (e.g., MinIO AIStor) default purgeRequested to true to work around Spark's bug where it doesn't forward purgeRequested=true even when DROP TABLE ... PURGE is used. With those catalogs, calling dropTable(identifier, false) would unexpectedly purge the table data because the parameter was omitted and the server defaulted to true. This change explicitly sends purgeRequested=false to ensure the client's intent is honored regardless of the server's default behavior. Relates to: apache#11023
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modify
RESTSessionCatalog.dropTable()to explicitly sendpurgeRequested=falseinstead of omitting the parameter.Problem
Currently,
dropTable(context, identifier)sends a DELETE request without thepurgeRequestedparameter, relying on the server to default tofalse.However, some catalogs default
purgeRequested=trueto work around Spark's bug where it doesn't forwardpurgeRequested=trueeven withDROP TABLE ... PURGE(#11023, #11317).With such catalogs, calling
catalog.dropTable(identifier, false)unexpectedly purges table data because the parameter is omitted and the server defaults totrue.Solution
Explicitly send
purgeRequested=false:This ensures the client's intent is honored regardless of server defaults.
Related Issues