SPEC: Add NoSuchPlanId to cancel endpoint #14796
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @geruh |
geruh
approved these changes
Dec 8, 2025
Contributor
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
LGTM, Nice catch @singhpk234!
nastra
approved these changes
Dec 9, 2025
amogh-jahagirdar
approved these changes
Dec 9, 2025
huaxingao
approved these changes
Dec 9, 2025
dramaticlly
approved these changes
Dec 12, 2025
Contributor
Author
|
Merging this, this seemed like a miss in the first and the implementation is already algined ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
Like drop table we should also throw no such plan id given that planId doesn't exist.