Use default-https-client for AWS SDK deps #2104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Author
|
if you decide to merge, would you please make a new release? Thanks! |
Avoid legacy rustls 0.21 pulled via AWS SDK defaults. Disable default features on aws-sdk-glue/aws-sdk-s3tables and explicitly enable default-https-client + rt-tokio, without legacy rustls. aws-config updtae to the recent version as it is already removed the legacy rustls 0.21 See note about changes to the default HTTPS client stack: awslabs/aws-sdk-rust#1257
igorscs
force-pushed
the
remove-obsolete-rustls-version
branch
from
c67d695 to
5dac49c
Compare
igorscs
pushed a commit
to feldera/feldera
that referenced
this pull request
Feb 4, 2026
We want to remove legacy rustls 0.21 from our code. Switch AWS SDK to default-https-client in the following crates aws-sdk-s3, aws-msk-iam-sasl-signer-rs, delta-lake: disable default features as their defaults bring legacy rustls, and add all features without rustls. In aws-config bump its version to the recent 1.8.13 as it doesn't include legacy rustls 0.21 anymore. See note about changes to the default HTTPS client stack awslabs/aws-sdk-rust#1257 We still use iceberg-glue-catalog that pulls absolite rustls 0.21 I made a PR for iceberg-rust crate to switch iceberg-glue-catalog to use a default-https-client and avoid pulling legacy rustls 0.21. apache/iceberg-rust#2104 Once it merges then I will update its version in our cargo files.
github-merge-queue bot
pushed a commit
to feldera/feldera
that referenced
this pull request
Feb 5, 2026
We want to remove legacy rustls 0.21 from our code. Switch AWS SDK to default-https-client in the following crates aws-sdk-s3, aws-msk-iam-sasl-signer-rs, delta-lake: disable default features as their defaults bring legacy rustls, and add all features without rustls. In aws-config bump its version to the recent 1.8.13 as it doesn't include legacy rustls 0.21 anymore. See note about changes to the default HTTPS client stack awslabs/aws-sdk-rust#1257 We still use iceberg-glue-catalog that pulls absolite rustls 0.21 I made a PR for iceberg-rust crate to switch iceberg-glue-catalog to use a default-https-client and avoid pulling legacy rustls 0.21. apache/iceberg-rust#2104 Once it merges then I will update its version in our cargo files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid legacy rustls 0.21 pulled via AWS SDK defaults.
Disable default features on aws-sdk-glue/aws-sdk-s3tables
and explicitly enable default-https-client + rt-tokio, without legacy rustls.
Update aws-config to the recent version 1.8.13 as it removed the legacy rustls 0.21 from its defaults.
See note about changes to the default HTTPS client stack
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?