Lazy pagination iterator for catalog list methods#3416
Open
GayathriSrividya wants to merge 2 commits into
Open
Lazy pagination iterator for catalog list methods#3416GayathriSrividya wants to merge 2 commits into
GayathriSrividya wants to merge 2 commits into
Conversation
Contributor
|
@GayathriSrividya To credit the original author, it would be good to cherry-pick his work |
7b6744e to
7e1538e
Compare
Author
|
Addressed the CI failures with follow-up commits and pushed fixes to this PR branch. |
Contributor
|
@GayathriSrividya was this based off of #2172? If it was, we should cherry-pick in the commits so that the original author shows up in this PR as well. |
Replace the collect-then-return approach with proper generator functions that yield results page by page. Extract per-page fetch logic into dedicated helper methods (_fetch_tables_page, _fetch_views_page, _fetch_namespaces_page) decorated with @Retry so authentication retries work correctly per page. Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
aa88377 to
54d8f64
Compare
Author
|
Hi @rambleraptor and @Fokko — yes, PR #3416 was based on @jayceslesar's work from #2172. I've restructured the branch to credit them properly:
All checks are passing on the latest push. Ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3365
This PR builds on @jayceslesar's earlier work in #2172 and has been restructured to credit the original author.
Changes
Commit 1 — by @jayceslesar (rebased from #2172):
list_tables,list_namespaces,list_viewsreturn types fromlist[Identifier]toIterator[Identifier]iter()of their resultsCommit 2 — by @GayathriSrividya:
_fetch_tables_page,_fetch_namespaces_page,_fetch_views_page) decorated with@retryso auth retry logic works correctly per page