Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

Rationale for this change

Previous use of del_branch_on_merge

github:
  del_branch_on_merge: true

is deprecated, https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#delete-branch-on-merge

New way is to

github:
  pull_requests:
    del_branch_on_merge: true

https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#pull_requests

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@geruh geruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Kevin! I was wondering why I had to manually cleanup now

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @kevinjqliu this is a great one, thanks @ebyhr and @geruh for the review 🙌

@Fokko Fokko merged commit 32c97ae into main Dec 1, 2025
8 checks passed
@Fokko Fokko deleted the kevinjqliu/asf-del_branch_on_merge branch December 1, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants