Skip to content

Conversation

@rambleraptor
Copy link
Contributor

Closes #2481

Rationale for this change

This allows users to run our test suite against their REST Catalog implementations.

Are these changes tested?

Test-only change

Are there any user-facing changes?

  • Adds support for running catalog tests against REST Catalog implementations.

@jayceslesar
Copy link
Contributor

I think under the contributing or dev or somewhere in the docs can we specify how a user would do this?

@rambleraptor
Copy link
Contributor Author

@jayceslesar I added docs in contributing that explains how to use this.

@rambleraptor rambleraptor requested a review from Fokko September 18, 2025 22:36
@gabeiglio
Copy link
Contributor

gabeiglio commented Sep 18, 2025

This is great! thanks for working on this! Im thinking for future next steps would be on thinking how we can allow for custom catalogs to ignore tests that are not supported by that catalog like for example catalogs that do not support views or multi-level namespaces, and so on.

We should somehow allow the users to selectively skip tests, like for example java CatalogTests

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really interesting idea. Thanks for adding it!

@rambleraptor
Copy link
Contributor Author

@kevinjqliu @Fokko @gabeiglio rebased and comments addressed! Thanks a lot

@Fokko
Copy link
Contributor

Fokko commented Sep 25, 2025

@rambleraptor Why do I still need to approve your runs? :D

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rambleraptor 🙌

@rambleraptor
Copy link
Contributor Author

@Fokko if there's a way for you to let me do CI runs, that would be awesome!

@Fokko
Copy link
Contributor

Fokko commented Sep 25, 2025

@rambleraptor I was under the impression that it should run after a merge. Let me check with infra

@rambleraptor
Copy link
Contributor Author

I've seen in past non-Apache OSS projects that automatic CI runs are limited to a specific set of people (typically committers, not always).

The idea behind that is that you don't want random malicious people sending PRs with Bitcoin mining scripts in them

@rambleraptor
Copy link
Contributor Author

@Fokko regardless, I changed the fixture name which should enable the tests to work. I'll try getting my integration test setup in a better situation to avoid having to rely on CI so much

@kevinjqliu kevinjqliu merged commit da47a4a into apache:main Sep 26, 2025
10 checks passed
@kevinjqliu
Copy link
Contributor

Thanks @rambleraptor for the PR and @gabeiglio @Fokko for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running CatalogTests against REST Catalog Implementations

5 participants