Block schema field drop if it is reference by an active partition or sort field #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeiglio
force-pushed
the
partition-spec-validation
branch
from
d4928bd to
81732d4
Compare
jayceslesar
approved these changes
Sep 17, 2025
Contributor
Anton-Tarazi
left a comment
Anton-Tarazi
left a comment
There was a problem hiding this comment.
Nice work, left a minor comment :)
…or sort order fields reference schema fields
gabeiglio
force-pushed
the
partition-spec-validation
branch
from
81732d4 to
7e47009
Compare
Contributor
Author
|
@Anton-Tarazi thanks for the review (this PR went off my radar) I have rebased and applied recommended changes |
geruh
reviewed
Dec 11, 2025
|
|
||
| for field in self.fields: | ||
| source_field = schema_fields.get(field.source_id) | ||
| if allow_missing_fields and source_field: |
Contributor
There was a problem hiding this comment.
Should this be:
if allow_missing_fields and source_field is None:
continue
| while parent_id: | ||
| parent_type = schema.find_type(parent_id) | ||
| if not parent_type.is_struct: | ||
| raise ValidationError("Invalid partition field parent: %s", parent_type) |
Contributor
There was a problem hiding this comment.
nit: should we also use f string here to align with others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2166
Rationale for this change
We should block when an user wants to drop a column if that column is being referenced by either a active partition spec or sort order field.
Are these changes tested?
Yes, I added unit tests for every incompatible schema change in partitions and sort orders. Also added two new integration tests in
test_catalogto test for this scenarioAre there any user-facing changes?
No