Skip to content

fix: correct grammar errors in schema.h comment #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Dec 30, 2025
Merged

fix: correct grammar errors in schema.h comment #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iceberg/schema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class ICEBERG_EXPORT Schema : public StructType {
/// Short names for maps and lists are included for any name that does not conflict with
/// a canonical name. For example, a list, 'l', of structs with field 'x' will produce
/// short name 'l.x' in addition to canonical name 'l.element.x'. A map 'm', if its
/// value include a structs with field 'x' wil produce short name 'm.x' in addition to
/// value includes a struct with field 'x' will produce short name 'm.x' in addition to
/// canonical name 'm.value.x'.
/// FIXME: Currently only handles ASCII lowercase conversion; extend to support
/// non-ASCII characters (e.g., using std::towlower or ICU)
Expand Down
Loading