refactor: add a manifest dir to hold all manifest related files #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve code organization by collecting manifest-related files. writer helpers are renamed with _internal.h suffix to prevent installation, keeping the public API clean.
wgtmac
reviewed
Nov 29, 2025
src/iceberg/type_fwd.h
Outdated
| class ManifestListWriter; | ||
| class ManifestReader; | ||
| class ManifestWriter; | ||
| class ManifestEntryAdapter; |
Member
There was a problem hiding this comment.
These two classes are not supposed to be used by downstream users. Should we remove them?
Collaborator
Author
There was a problem hiding this comment.
Reasonable, removed, I also make the ctor of ManifestWriter and ManifestListWriter private.
wgtmac
reviewed
Nov 29, 2025
shangxinli
reviewed
Nov 29, 2025
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| install_headers( |
Contributor
There was a problem hiding this comment.
Do we need to be consistent with CMakeLists.txt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code organization by collecting manifest-related files into a dedicate directory. Writer helpers are renamed with _internal.h suffix to prevent installation, keeping the public API clean.