refactor: make ConfigBase subclass constructors private #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuaHuaY
approved these changes
Nov 29, 2025
zhjwpku
approved these changes
Nov 29, 2025
shangxinli
reviewed
Nov 29, 2025
|
|
||
| std::unique_ptr<ReaderProperties> ReaderProperties::default_properties() { | ||
| return std::make_unique<ReaderProperties>(); | ||
| return std::unique_ptr<ReaderProperties>(new ReaderProperties()); |
Contributor
There was a problem hiding this comment.
For this specific case is actually safe because it is single expression, immediately returned and no other allocations happening. But I thought we generally prefer to use make_unique for it's safety.
Contributor
There was a problem hiding this comment.
std::make_unique needs a public constructor, so it can't be used when constructor is marked to private.
wgtmac
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.