Skip to content

Conversation

@dongxiao1198
Copy link
Contributor

@dongxiao1198 dongxiao1198 commented Nov 28, 2025

fix result.h cpplint fail after upgraded to gcc14

@dongxiao1198 dongxiao1198 changed the title test: test cpplint build fix: result.h cpplint fail after upgraded to gcc14 Nov 28, 2025
@dongxiao1198 dongxiao1198 changed the title fix: result.h cpplint fail after upgraded to gcc14 fix: result.h cpplint failed after upgraded to gcc14 Nov 28, 2025
@HuaHuaY
Copy link
Contributor

HuaHuaY commented Nov 28, 2025

The reason for this problem is a bit complex:

  1. Arrow cannot be compiled under GCC14 with C++23. So we set CMAKE_CXX_STANDARD 17 for arrow.
  2. After clang-tidy reads compile_commands.json, it believes that result.h might be included by arrow and sees a -std=c++17 flag in arrow's compilation commands.
  3. Clang-tidy assumes that result.h should also be compiled under C++17.

I think the solution to this problem is to force clang-tidy to compile under C++23. You can find my test PR #365. It compiles result.h successfully with cpp-linter extra-args: '-std=c++23 ...'.

I have opened a new PR #367 to fix this issue.

@wgtmac
Copy link
Member

wgtmac commented Dec 1, 2025

Thanks @HuaHuaY for investigation! Let me close this as it is fixed in another PR.

@wgtmac wgtmac closed this Dec 1, 2025
@dongxiao1198 dongxiao1198 deleted the test_result branch December 5, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants