Skip to content

refactor: add final when class will not be inherited #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Nov 27, 2025
Merged

refactor: add final when class will not be inherited #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/iceberg/catalog/rest/error_handlers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class ICEBERG_REST_EXPORT NamespaceErrorHandler : public DefaultErrorHandler {
};

/// \brief Error handler for drop namespace operations.
class ICEBERG_REST_EXPORT DropNamespaceErrorHandler : public NamespaceErrorHandler {
class ICEBERG_REST_EXPORT DropNamespaceErrorHandler final : public NamespaceErrorHandler {
public:
/// \brief Returns the singleton instance
static const std::shared_ptr<DropNamespaceErrorHandler>& Instance();
Expand All @@ -83,7 +83,7 @@ class ICEBERG_REST_EXPORT DropNamespaceErrorHandler : public NamespaceErrorHandl
};

/// \brief Table-level error handler.
class ICEBERG_REST_EXPORT TableErrorHandler : public DefaultErrorHandler {
class ICEBERG_REST_EXPORT TableErrorHandler final : public DefaultErrorHandler {
public:
/// \brief Returns the singleton instance
static const std::shared_ptr<TableErrorHandler>& Instance();
Expand All @@ -95,7 +95,7 @@ class ICEBERG_REST_EXPORT TableErrorHandler : public DefaultErrorHandler {
};

/// \brief View-level error handler.
class ICEBERG_REST_EXPORT ViewErrorHandler : public DefaultErrorHandler {
class ICEBERG_REST_EXPORT ViewErrorHandler final : public DefaultErrorHandler {
public:
/// \brief Returns the singleton instance
static const std::shared_ptr<ViewErrorHandler>& Instance();
Expand All @@ -107,7 +107,7 @@ class ICEBERG_REST_EXPORT ViewErrorHandler : public DefaultErrorHandler {
};

/// \brief Table commit operation error handler.
class ICEBERG_REST_EXPORT TableCommitErrorHandler : public DefaultErrorHandler {
class ICEBERG_REST_EXPORT TableCommitErrorHandler final : public DefaultErrorHandler {
public:
/// \brief Returns the singleton instance
static const std::shared_ptr<TableCommitErrorHandler>& Instance();
Expand All @@ -119,7 +119,7 @@ class ICEBERG_REST_EXPORT TableCommitErrorHandler : public DefaultErrorHandler {
};

/// \brief View commit operation error handler.
class ICEBERG_REST_EXPORT ViewCommitErrorHandler : public DefaultErrorHandler {
class ICEBERG_REST_EXPORT ViewCommitErrorHandler final : public DefaultErrorHandler {
public:
/// \brief Returns the singleton instance
static const std::shared_ptr<ViewCommitErrorHandler>& Instance();
Expand Down
Loading