feat: implement struct like for partition values #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wgtmac
commented
Nov 27, 2025
wgtmac
commented
- Added PartitionValues to extend StructLike
- Implemented PartitionMap
- Implemented PartitionSet
wgtmac
force-pushed
the
partiton_values
branch
2 times, most recently
from
6ef1541 to
a32d153
Compare
- Added PartitionValues to extend StructLike - Implemented PartitionMap - Implemented PartitionSet
wgtmac
force-pushed
the
partiton_values
branch
from
a32d153 to
318b343
Compare
zhjwpku
approved these changes
Nov 27, 2025
Collaborator
zhjwpku
left a comment
zhjwpku
left a comment
There was a problem hiding this comment.
LGTM, ValueAt makes the code more safe.
shangxinli
reviewed
Nov 28, 2025
shangxinli
reviewed
Nov 28, 2025
Contributor
|
LGTM |
shangxinli
approved these changes
Nov 28, 2025
Contributor
|
Thanks @shangxinli @dongxiao1198, and @zhjwpku for the reviews 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.