feat: add ExpireSnapshots interface #350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ExpireSnapshots interface for removing old snapshots from tables. This interface extends PendingUpdate directly and provides methods for: - ExpireSnapshotId: Expire specific snapshots by ID - ExpireOlderThan: Expire snapshots older than a timestamp - RetainLast: Keep N most recent snapshots - DeleteWith: Custom file deletion callback - CleanupLevel: Control cleanup scope (none, metadata only, or all) The implementation includes comprehensive tests that verify behavior through the public API and follows the Java Iceberg API design.
Member
|
IMHO, we don't need to follow the Java design here to introduce pure interface which has only one concrete implementation. I have created #364 to track what's in my mind. Let me know what you think. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ExpireSnapshots interface for removing old snapshots from tables. This interface extends PendingUpdate directly and provides methods for:
The implementation includes comprehensive tests that verify behavior through the public API and follows the Java Iceberg API design.