Skip to content

feat: add expression evaluators #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongxiao1198 wants to merge 1 commit into from
Closed

feat: add expression evaluators #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/iceberg/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@ set(ICEBERG_SOURCES
expression/expression.cc
expression/expressions.cc
expression/literal.cc
expression/manifest_evaluator.cc
expression/predicate.cc
expression/rewrite_not.cc
expression/residual_evaluator.cc
expression/inclusive_metrics_evaluator.cc
expression/strict_metrics_evaluator.cc
expression/term.cc
file_reader.cc
file_writer.cc
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/expression/expression_visitor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ class ICEBERG_EXPORT BoundVisitor : public ExpressionVisitor<R> {
/// Bound visitors do not support unbound predicates.
///
/// \param pred The unbound predicate
Result<R> Predicate(const std::shared_ptr<UnboundPredicate>& pred) final {
Result<R> Predicate(const std::shared_ptr<UnboundPredicate>& pred) override {
ICEBERG_DCHECK(pred != nullptr, "UnboundPredicate cannot be null");
return NotSupported("Not a bound predicate: {}", pred->ToString());
}
Expand Down
Loading
Loading