Skip to content

fix: shared library uses hidden visibility by default #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Nov 21, 2025
Merged

fix: shared library uses hidden visibility by default #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmake_modules/IcebergBuildUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ function(add_iceberg_lib LIB_NAME)

string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
target_compile_definitions(${LIB_NAME}_shared PRIVATE ${VISIBILITY_NAME}_EXPORTING)
set_target_properties(${LIB_NAME}_shared
PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET
hidden
VISIBILITY_INLINES_HIDDEN 1)

install(TARGETS ${LIB_NAME}_shared
EXPORT iceberg_targets
Expand Down Expand Up @@ -211,8 +215,10 @@ function(add_iceberg_lib LIB_NAME)
target_link_libraries(${LIB_NAME}_static
PUBLIC "$<BUILD_INTERFACE:iceberg_sanitizer_flags>")

string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
target_compile_definitions(${LIB_NAME}_static PUBLIC ${VISIBILITY_NAME}_STATIC)
if(WIN32)
string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
target_compile_definitions(${LIB_NAME}_static PUBLIC ${VISIBILITY_NAME}_STATIC)
endif()

install(TARGETS ${LIB_NAME}_static
EXPORT iceberg_targets
Expand Down
Loading