feat: add eval support to bound term #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wgtmac
commented
Nov 14, 2025
wgtmac
commented
- add struct like accessor
- support schema to find accessor by field id
- bound term can evaluate struct-like
- add struct like accessor - support schema to find accessor by field id - bound term can evaluate struct-like
zhjwpku
approved these changes
Nov 16, 2025
| return Literal::Fixed(std::vector<uint8_t>(fixed_data.cbegin(), fixed_data.cend())); | ||
| } | ||
| case TypeId::kUuid: | ||
| // TODO(gangwu): Implement UUID type |
Collaborator
There was a problem hiding this comment.
We seems to have a Uuid class under util dir, can we use that?
Member
Author
There was a problem hiding this comment.
I have created #314 to address all aspects of the uuid data type. I think the missing parts are more than the scalar part.
HuaHuaY
approved these changes
Nov 19, 2025
liurenjie1024
approved these changes
Nov 19, 2025
Member
Author
|
Thanks @zhjwpku @HuaHuaY @liurenjie1024 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.