chore: add support to customize download url of vendored dependencies #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
reviewed
Nov 14, 2025
wgtmac
requested changes
Nov 19, 2025
Contributor
Author
|
@wgtmac Thank you for the feedback I have addressed both of your comments Documented all ICEBERG_*_URL environment variables at the top of IcebergThirdpartyToolchain.cmake (L24-40) The PR now only adds optional environment variables with documentation keeping everything flexible without region-specific docs. |
zhjwpku
reviewed
Nov 21, 2025
wgtmac
approved these changes
Nov 25, 2025
wgtmac
changed the title
Member
|
Thanks for improving this! @Subham-KRLX Thanks @zhjwpku @Xuanwo @HuaHuaY for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239