Skip to content

Conversation

@zhjwpku
Copy link
Collaborator

@zhjwpku zhjwpku commented Nov 12, 2025

closes #303

# This Dockerfile is used to build a development container for Iceberg C++.
# It is based on the Ubuntu image and installs necessary dependencies.

FROM ubuntu:24.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move this to a dedicated dev/docker folder? We might want to add a dockerfile for the rest catalog server as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's move it into .devcontainer, then it will not affect other dockerfiles.

@HuaHuaY
Copy link
Contributor

HuaHuaY commented Nov 13, 2025

Should we add some file extensions such as .sample to these files and add a .gitignore file in .devcontainer. Its content may be like these:

*
!*.sample

When somebody needs dev container, he can copy these files and remove .sample. It allows somebody modifies the container configuation without producing a git record.

@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Nov 13, 2025

Should we add some file extensions such as .sample to these files and add a .gitignore file in .devcontainer. Its content may be like these:

*
!*.sample

When somebody needs dev container, he can copy these files and remove .sample. It allows somebody modifies the container configuation without producing a git record.

Perhaps just add .devcontainer to .gitignore. If we really need to commit changes to it, we can use git add --force.

@HuaHuaY
Copy link
Contributor

HuaHuaY commented Nov 13, 2025

Should we add some file extensions such as .sample to these files and add a .gitignore file in .devcontainer. Its content may be like these:

*
!*.sample

When somebody needs dev container, he can copy these files and remove .sample. It allows somebody modifies the container configuation without producing a git record.

Perhaps just add .devcontainer to .gitignore. If we really need to commit changes to it, we can use git add --force.

Changes in a tracked file will not be ignored by .gitignore. This PR adds .devcontainer so the modifition in the future in .devcontainer will never be ignored by .gitignore.

@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Nov 13, 2025

Changes in a tracked file will not be ignored by .gitignore. This PR adds .devcontainer so the modifition in the future in .devcontainer will never be ignored by .gitignore.

Makes sense. I've updated the files with .sample suffix and added a new section to the README. Please take a look.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start! I think we can later add commands to build Arrow and Avro from source and also install other dependencies like nanoarrow, etc.

@wgtmac wgtmac merged commit acd62e3 into apache:main Nov 14, 2025
10 checks passed
@wgtmac
Copy link
Member

wgtmac commented Nov 14, 2025

Merged this. Thanks @zhjwpku and @HuaHuaY!

@zhjwpku zhjwpku deleted the add_dev_container branch November 30, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is Docker compilation not supported?

3 participants