-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add devcontainer #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # This Dockerfile is used to build a development container for Iceberg C++. | ||
| # It is based on the Ubuntu image and installs necessary dependencies. | ||
|
|
||
| FROM ubuntu:24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to move this to a dedicated dev/docker folder? We might want to add a dockerfile for the rest catalog server as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's move it into .devcontainer, then it will not affect other dockerfiles.
|
Should we add some file extensions such as When somebody needs dev container, he can copy these files and remove |
Perhaps just add .devcontainer to .gitignore. If we really need to commit changes to it, we can use |
Changes in a tracked file will not be ignored by .gitignore. This PR adds |
Makes sense. I've updated the files with |
Co-authored-by: Gang Wu <ustcwg@gmail.com>
wgtmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start! I think we can later add commands to build Arrow and Avro from source and also install other dependencies like nanoarrow, etc.
closes #303