Skip to content

refactor: Remove redundant SparkAdapter methods#18293

Draft
yihua wants to merge 1 commit intoapache:masterfrom
yihua:refactor-remove-redundant-spark-adapter-apis
Draft

refactor: Remove redundant SparkAdapter methods#18293
yihua wants to merge 1 commit intoapache:masterfrom
yihua:refactor-remove-redundant-spark-adapter-apis

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Mar 8, 2026

Describe the issue this Pull Request addresses

Summary and Changelog

Impact

Risk Level

Documentation Update

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Mar 8, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.31%. Comparing base (ec04479) to head (8328b49).
⚠️ Report is 1024 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala 26.31% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18293      +/-   ##
============================================
- Coverage     61.43%   57.31%   -4.12%     
+ Complexity    23082    18606    -4476     
============================================
  Files          2108     1954     -154     
  Lines        127636   106858   -20778     
  Branches      14534    13194    -1340     
============================================
- Hits          78409    61244   -17165     
+ Misses        42873    39838    -3035     
+ Partials       6354     5776     -578     
Flag Coverage Δ
hadoop-mr-java-client 45.21% <ø> (?)
spark-java-tests 47.48% <26.31%> (?)
spark-scala-tests 45.58% <26.31%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/spark/sql/adapter/Spark3_3Adapter.scala 77.77% <ø> (ø)
...org/apache/spark/sql/adapter/Spark3_4Adapter.scala 75.00% <ø> (ø)
...org/apache/spark/sql/adapter/Spark3_5Adapter.scala 75.67% <ø> (ø)
...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala 58.49% <26.31%> (ø)

... and 4016 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Mar 8, 2026

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants