Add RFC 7639 canonical percent codec for ALPN protocol identifiers. #596
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve token tchar octets (except '%') and enforce uppercase hex.
ok2c
approved these changes
Jan 12, 2026
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
and guarantees uppercase hex
@arturobernalg I do not see any changes in the behavior of the codec to that effect but so be it.
|
|
||
| private final BitSet unreserved; | ||
|
|
||
| private PercentCodec(final BitSet unreserved) { |
Member
There was a problem hiding this comment.
@arturobernalg Let's make the constructor public and mark it @Internal
Member
|
@arturobernalg Could there be a better name than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce PercentCodec.RFC7639 for canonical ALPN protocol-id encoding per RFC 7639.
Avoids over-encoding of valid tchar octets compared to RFC3986 and guarantees uppercase hex.