Skip to content

Enable five-second TCP keep-alive by default #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschmitt merged 1 commit into from
Sep 20, 2025
Merged

Enable five-second TCP keep-alive by default #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions httpcore5/src/main/java/org/apache/hc/core5/http/io/SocketConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,14 @@ public static class Builder {
this.soTimeout = DEFAULT_SOCKET_TIMEOUT;
this.soReuseAddress = false;
this.soLinger = TimeValue.NEG_ONE_SECOND;
this.soKeepAlive = false;
this.soKeepAlive = true;
this.tcpNoDelay = true;
this.sndBufSize = 0;
this.rcvBufSize = 0;
this.backlogSize = 0;
this.tcpKeepIdle = -1;
this.tcpKeepInterval = -1;
this.tcpKeepCount = -1;
this.tcpKeepIdle = 5;
this.tcpKeepInterval = 5;
this.tcpKeepCount = 3;
this.socksProxyAddress = null;
}

Expand Down Expand Up @@ -318,7 +318,7 @@ public Builder setSoLinger(final TimeValue soLinger) {
* Determines the default value of the {@link SocketOptions#SO_KEEPALIVE} parameter
* for newly created sockets.
* <p>
* Default: {@code false}
* Default: {@code true}
* </p>
*
* @return this instance.
Expand Down Expand Up @@ -395,7 +395,7 @@ public Builder setBacklogSize(final int backlogSize) {
* Determines the time (in seconds) the connection needs to remain idle before TCP starts
* sending keepalive probes.
* <p>
* Default: {@code -1} (system default)
* Default: {@code 5}
* </p>
*
* @return this instance.
Expand All @@ -409,7 +409,7 @@ public Builder setTcpKeepIdle(final int tcpKeepIdle) {
/**
* Determines the time (in seconds) between individual keepalive probes.
* <p>
* Default: {@code -1} (system default)
* Default: {@code 5}
* </p>
*
* @return this instance.
Expand All @@ -423,7 +423,7 @@ public Builder setTcpKeepInterval(final int tcpKeepInterval) {
/**
* Determines the maximum number of keepalive probes TCP should send before dropping the connection.
* <p>
* Default: {@code -1} (system default)
* Default: {@code 3}
* </p>
*
* @return this instance.
Expand Down
19 changes: 14 additions & 5 deletions httpcore5/src/main/java/org/apache/hc/core5/reactor/IOReactorConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,15 +318,15 @@ public static void setDefaultMaxIOThreadCount(final int defaultMaxIOThreadCount)
this.soTimeout = Timeout.ZERO_MILLISECONDS;
this.soReuseAddress = false;
this.soLinger = TimeValue.NEG_ONE_SECOND;
this.soKeepAlive = false;
this.soKeepAlive = true;
this.tcpNoDelay = true;
this.trafficClass = 0;
this.sndBufSize = 0;
this.rcvBufSize = 0;
this.backlogSize = 0;
this.tcpKeepIdle = -1;
this.tcpKeepInterval = -1;
this.tcpKeepCount = -1;
this.tcpKeepIdle = 5;
this.tcpKeepInterval = 5;
this.tcpKeepCount = 3;
this.socksProxyAddress = null;
this.socksProxyUsername = null;
this.socksProxyPassword = null;
Expand Down Expand Up @@ -436,7 +436,7 @@ public Builder setSoLinger(final TimeValue soLinger) {
* Sets the default value of the {@link SocketOptions#SO_KEEPALIVE} parameter
* for newly created sockets.
* <p>
* Default: {@code -1}
* Default: {@code true}
* </p>
*
* @return this instance.
Expand Down Expand Up @@ -526,6 +526,9 @@ public Builder setBacklogSize(final int backlogSize) {
/**
* Sets the time (in seconds) the connection needs to remain idle before TCP starts
* sending keepalive probes.
* <p>
* Default: {@code 5}
* </p>
*
* @return this instance.
* @since 5.3
Expand All @@ -537,6 +540,9 @@ public Builder setTcpKeepIdle(final int tcpKeepIdle) {

/**
* Sets the time (in seconds) between individual keepalive probes.
* <p>
* Default: {@code 5}
* </p>
*
* @return this instance.
* @since 5.3
Expand All @@ -548,6 +554,9 @@ public Builder setTcpKeepInterval(final int tcpKeepInterval) {

/**
* Sets the maximum number of keepalive probes TCP should send before dropping the connection.
* <p>
* Default: {@code 3}
* </p>
*
* @return this instance.
* @since 5.3
Expand Down