h2: add choosing framefactory impl #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hello @psmarko |
ok2c
requested changes
Jun 8, 2025
...ore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2RequesterBootstrap.java
Show resolved
Hide resolved
Contributor
Author
|
I'm not familiar enough to find a similar test case. Could you refer me to an existing test case I could follow? Thank you. |
ok2c
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FrameFactory interface is useful as, for example, it allows patching in PRIORITY support and changing frame values that are not generally configurable. It is set to the default impl in ClientH2StreamMultiplexerFactory making it hard to change. This PR adds the appropriate setter methods into ClientH2StreamMultiplexerFactory and H2RequesterBootstrap to choose a FrameFactory impl as so: