Avoid legacy Socket API in reactor code #520
Merged
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Socket` API is considered tightly coupled to Internet Protocol, and `socketChannel.socket()` is effectively a kind of unchecked downcast which will throw an exception if called on a Unix domain SocketChannel. This change removes some trivial coupling to `Socket` in preparation for introducing support for JEP 380 Unix domain sockets.
ok2c
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SocketAPI is considered tightly coupled to Internet Protocol, andsocketChannel.socket()is effectively a kind of unchecked downcast which will throw an exception if called on a Unix domainSocketChannel. This change removes some trivial coupling toSocketin preparation for introducing support for JEP 380 Unix domain sockets.