Skip to content

Conversation

@ok2c
Copy link
Member

@ok2c ok2c commented Oct 19, 2025

Presently the content compression executors remove headers content related headers from the original response message to make it consistent with properties of the content entity. This is conceptually wrong. The content entity associated with the response message has its own content properties (content-length, content-type, content-encoding, etc) that can differ from those of the original message. As long as those properties correctly reflect the content produced be the entity there is no need to mutate the original response message itself, and there can be legitimate reasons for the caller to see the actual response headers.

I propose we change the content compression executors to stop removing content related headers from the original response message,

@ok2c ok2c requested a review from arturobernalg October 19, 2025 17:00
@arturobernalg
Copy link
Member

  • 1 Keeping the original response headers intact is more correct semantically

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok2c ok2c force-pushed the content_compression_original_response branch from 807bf54 to ecae602 Compare October 20, 2025 06:22
@ok2c ok2c merged commit 56122fd into apache:master Oct 20, 2025
10 checks passed
@ok2c ok2c deleted the content_compression_original_response branch October 26, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants