Asyn brotli reflection

[arturobernalg]

Make DeflatingBrotliEntityProducer and InflatingBrotliDataConsumer load brotli4j via reflection.
Removes hard dependencies and avoids linkage errors when Brotli is absent.

[ok2c]

@arturobernalg Why are we actually doing all this? AsyncBrotli is completely unintelligible now. Moreover, the current master works absolutely correctly for me. I tested it with various combinations of having and not having optional dependencies on the classpath and everything worked for me as expected. In fact, we presently do unnecessary reflective calls in CommonsCompressCodecFactory in my opinion. It is not a problem that it directly imports org.apache.commons.compress.compressors classes at compile time. What is important is that it never gets called from ContentCodecRegistry at runtime if Commons Compress is not present.

What am i missing?

[arturobernalg]

@arturobernalg Why are we actually doing all this? AsyncBrotli is completely unintelligible now. Moreover, the current master works absolutely correctly for me. I tested it with various combinations of having and not having optional dependencies on the classpath and everything worked for me as expected. In fact, we presently do unnecessary reflective calls in CommonsCompressCodecFactory in my opinion. It is not a problem that it directly imports org.apache.commons.compress.compressors classes at compile time. What is important is that it never gets called from ContentCodecRegistry at runtime if Commons Compress is not present.

What am i missing?

@ok2c
I assumed the goal was zero compile-time references to optional codecs and pushed everything behind reflection to avoid any potential linkage issues.

[ok2c]

@arturobernalg I think it was a misunderstanding.

The problem was this bit of code that used CommonsCompressDecoderFactory#runtimeAvailable to test for availability of Brotli even if Commons Compress was not on the classpath. There is no problem linking optional dependencies at compile time.

        if (!m.containsKey(ContentCoding.BROTLI)
                && CommonsCompressDecoderFactory.runtimeAvailable(ContentCoding.BROTLI.token())) {
            m.put(ContentCoding.BROTLI,
                    Codec.decodeOnly(ent ->
                            new DecompressingEntity(ent, BrotliInputStream::new)));
        }

I once again did a poor job reviewing your changes but I will try to improve.

I fixed all these problems with 4a34b97