ConnectionConfig: Add idleTimeout #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Oct 8, 2025
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java
Show resolved
Hide resolved
Member
|
@rschmitt I suppose we should rewrite |
Connection TTL can be effected either in bulk by calling `connMgr.closeExpired()` or at connection reuse time by configuring a `timeToLive` on the `ConnectionConfig`. Strangely, idle timeouts can only be effected in bulk via `connMgr.closeIdle()`, or with an `IdleConnectionEvictor`; they have no corresponding `ConnectionConfig` setting. This change resolves this inconsistency. The result is that idle timeouts are much easier to configure and enforce: they don't require spinning up a background thread that periodically locks the entire conn pool and closes idle connections; there is no longer the possibility of reusing a connection after it hits its intended idle timeout; and it doesn't matter whether the connection pool is shared.
rschmitt
force-pushed
the
idle-timeout
branch
from
b82e404 to
98e5c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection TTL can be effected either in bulk by calling
connMgr.closeExpired()or at connection reuse time by configuring atimeToLiveon theConnectionConfig. Strangely, idle timeouts can only be effected in bulk viaconnMgr.closeIdle(), or with anIdleConnectionEvictor; they have no correspondingConnectionConfigsetting. This change resolves this inconsistency. The result is that idle timeouts are much easier to configure and enforce: they don't require spinning up a background thread that periodically locks the entire conn pool and closes idle connections; there is no longer the possibility of reusing a connection after it hits its intended idle timeout; and it doesn't matter whether the connection pool is shared.