Skip to content

Remove unreachable break after throw in TUNNEL_PROXY branch #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturobernalg merged 1 commit into from
Oct 5, 2025
+3 −11
Merged

Remove unreachable break after throw in TUNNEL_PROXY branch #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,18 +163,10 @@ public ClassicHttpResponse execute(
break;

case HttpRouteDirector.TUNNEL_PROXY: {
// The most simple example for this case is a proxy chain
// of two proxies, where P1 must be tunnelled to P2.
// route: Source -> P1 -> P2 -> Target (3 hops)
// fact: Source -> P1 -> Target (2 hops)
final int hop = fact.getHopCount() - 1; // the hop to establish
final boolean secure = createTunnelToProxy(route, hop, context);
if (LOG.isDebugEnabled()) {
LOG.debug("{} tunnel to proxy created.", exchangeId);
}
tracker.tunnelProxy(route.getHopTarget(hop), secure);
// Proxy chains are not supported by HttpClient.
// Fail fast instead of attempting an untested tunnel to an intermediate proxy.
throw new HttpException("Proxy chains are not supported.");
}
break;

case HttpRouteDirector.LAYER_PROTOCOL:
execRuntime.upgradeTls(context);
Expand Down