HTTPCLIENT-2395: Avoid double-encoding of RFC 5987 filename* and pass through pre-encoded values #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
reviewed
Sep 14, 2025
| if (value.startsWith("UTF-8''")) { | ||
| writeBytes(value, StandardCharsets.US_ASCII, out); | ||
| } else { | ||
| final String encodedValue = "UTF-8''" + PercentCodec.RFC5987.encode(value); |
Member
There was a problem hiding this comment.
@arturobernalg Could you please use StringBuilder and PercentCodec#encode(StringBuilder, CharSequence) here? Small optimization but still a bit less garbage.
… through pre-encoded values. Make ConnPoolSupport.formatStats null-safe to prevent NPEs during lease/shutdown. Add multipart tests covering EXTENDED mode and pre-encoded filename*.
arturobernalg
force-pushed
the
HTTPCLIENT-2395
branch
from
00281ce to
6407dbb
Compare
ok2c
approved these changes
Sep 14, 2025
Member
Author
|
@ok2c cherry-pick to 5.5.x. as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ConnPoolSupport.formatStats null-safe to prevent NPEs during lease/shutdown. Add multipart tests covering EXTENDED mode and pre-encoded filename*.