-
Notifications
You must be signed in to change notification settings - Fork 983
Add SCRAM-SHA-256 (RFC 7804) #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ScramException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * ==================================================================== | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| * ==================================================================== | ||
| * | ||
| * This software consists of voluntary contributions made by many | ||
| * individuals on behalf of the Apache Software Foundation. For more | ||
| * information on the Apache Software Foundation, please see | ||
| * <http://www.apache.org/>. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.hc.client5.http.impl; | ||
|
|
||
| import org.apache.hc.client5.http.auth.AuthenticationException; | ||
|
|
||
| /** | ||
| * Represents an exception that occurs during SCRAM (Salted Challenge Response Authentication Mechanism) authentication. | ||
| * <p> | ||
| * SCRAM is a family of SASL mechanisms used for secure authentication. This exception is thrown when | ||
| * an error or issue is encountered during the SCRAM authentication process. | ||
| * </p> | ||
| * | ||
| * @since 5.6 | ||
| */ | ||
| public class ScramException extends AuthenticationException { | ||
|
|
||
| private static final long serialVersionUID = 2491660491058647342L; | ||
|
|
||
| /** | ||
| * Constructs a new {@code ScramException} with {@code null} as its detail message. | ||
| * The cause is not initialized and may be subsequently initialized by a call to {@link #initCause}. | ||
| */ | ||
| public ScramException() { | ||
| super(); | ||
| } | ||
|
|
||
| /** | ||
| * Constructs a new {@code ScramException} with the specified detail message. | ||
| * The cause is not initialized and may be subsequently initialized by a call to {@link #initCause}. | ||
| * | ||
| * @param message the detail message, saved for later retrieval by the {@link #getMessage()} method. | ||
| */ | ||
| public ScramException(final String message) { | ||
| super(message); | ||
| } | ||
|
|
||
| /** | ||
| * Constructs a new {@code ScramException} with the specified detail message and cause. | ||
| * | ||
| * @param message the detail message, saved for later retrieval by the {@link #getMessage()} method. | ||
| * @param cause the cause, saved for later retrieval by the {@link #getCause()} method. | ||
| * A {@code null} value indicates that the cause is nonexistent or unknown. | ||
| */ | ||
| public ScramException(final String message, final Throwable cause) { | ||
| super(message, cause); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This order is of course questionable because if
Beareris peformed viaclient_credentialsfirst it isn't better than SCRAM, from my PoV