Skip to content

HTTPCLIENT-2388: fix builder default evictor sleepTime #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 1 commit into from
Aug 28, 2025
Merged

HTTPCLIENT-2388: fix builder default evictor sleepTime #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.LinkedList;
import java.util.List;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;
import java.util.function.UnaryOperator;

Expand Down Expand Up @@ -158,6 +159,8 @@
*/
public class HttpAsyncClientBuilder {

private static final TimeValue ONE_SECOND = TimeValue.ofSeconds(1L);

private static class RequestInterceptorEntry {

enum Position { FIRST, LAST }
Expand Down Expand Up @@ -1094,8 +1097,10 @@ public CloseableHttpAsyncClient build() {
}
if (evictExpiredConnections || evictIdleConnections) {
if (connManagerCopy instanceof ConnPoolControl) {
TimeValue sleepTime = maxIdleTime.divide(10, TimeUnit.NANOSECONDS);
sleepTime = sleepTime.compareTo(ONE_SECOND) < 0 ? ONE_SECOND : sleepTime;
final IdleConnectionEvictor connectionEvictor = new IdleConnectionEvictor((ConnPoolControl<?>) connManagerCopy,
maxIdleTime, maxIdleTime);
sleepTime, maxIdleTime);
closeablesCopy.add(connectionEvictor::shutdown);
connectionEvictor.start();
}
Expand Down
7 changes: 6 additions & 1 deletion httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;
import java.util.function.UnaryOperator;

Expand Down Expand Up @@ -145,6 +146,8 @@
*/
public class HttpClientBuilder {

private static final TimeValue ONE_SECOND = TimeValue.ofSeconds(1L);

private static class RequestInterceptorEntry {

enum Position { FIRST, LAST }
Expand Down Expand Up @@ -1105,8 +1108,10 @@ public CloseableHttpClient build() {
}
if (evictExpiredConnections || evictIdleConnections) {
if (connManagerCopy instanceof ConnPoolControl) {
TimeValue sleepTime = maxIdleTime.divide(10, TimeUnit.NANOSECONDS);
sleepTime = sleepTime.compareTo(ONE_SECOND) < 0 ? ONE_SECOND : sleepTime;
final IdleConnectionEvictor connectionEvictor = new IdleConnectionEvictor((ConnPoolControl<?>) connManagerCopy,
maxIdleTime, maxIdleTime);
sleepTime, maxIdleTime);
closeablesCopy.add(() -> {
connectionEvictor.shutdown();
try {
Expand Down
Loading