Skip to content

Conversation

@arturobernalg
Copy link
Member

Implement async handling of multi-hop proxy routes with CONNECT requests Update test to verify successful proxy chain establishment

Implement async handling of multi-hop proxy routes with CONNECT requests
Update test to verify successful proxy chain establishment
@arturobernalg arturobernalg requested a review from ok2c July 24, 2025 19:06
@ok2c
Copy link
Member

ok2c commented Jul 25, 2025

@arturobernalg Have you been able to test it in real-life settings with multiple proxy servers forming a proxy chain?

Then, we would also need to make similar changes to the classic ConnectExec.

@arturobernalg
Copy link
Member Author

@arturobernalg Have you been able to test it in real-life settings with multiple proxy servers forming a proxy chain?

Then, we would also need to make similar changes to the classic ConnectExec.

The classic already have a implementations --> https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java#L165

@ok2c
Copy link
Member

ok2c commented Jul 27, 2025

@arturobernalg Have you been able to test it in real-life settings with multiple proxy servers forming a proxy chain?
Then, we would also need to make similar changes to the classic ConnectExec.

The classic already have a implementations --> https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java#L165

@arturobernalg That code is likely wrong or broken or both. There is not a single integration test case that exercises it. Instead of adding similarly broken code in the async pipeline we should rather remove it from the classic one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants