HTTPCLIENT-2383 Bypass sensitive-header check in LaxRedirectStrategy #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Override isRedirectAllowed(...) to always return true, ensuring LaxRedirectStrategy follows redirects regardless of Authorization or other sensitive headers.
|
@arturobernalg : it's really refreshing to see how quickly you've managed to sort out this regression. I'm sure many people appreciate your efforts! Thanks a lot ❤️ Kudos for @dani0600 for reporting it as well. |
|
Thanks a lot, @arturobernalg, for taking care of this so quickly! We really appreciate your responsiveness and the continued effort you put into improving these tools — it benefits so many of us! |
|
Included some more tests here: #677 that could be interesting for you |
ok2c
approved these changes
Jul 16, 2025
…itive headers are part of the request
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LaxRedirectStrategynow overridesisRedirectAllowedto always return true so that redirects are followed even when sensitive headers like Authorization are present.