Skip to content

Conversation

@arturobernalg
Copy link
Member

Adapt InputStreamFactory map into contentDecoder via DecompressingEntity adapters

Adapt InputStreamFactory map into contentDecoder via DecompressingEntity adapters
@arturobernalg arturobernalg requested a review from ok2c July 15, 2025 09:02
@ok2c
Copy link
Member

ok2c commented Jul 16, 2025

@arturobernalg I spotted another problem. The LinkedHashMap<ContentCoding, UnaryOperator<HttpEntity>> map used by HttpClientBuilder basically means one cannot plug-in 3rd party coders if they are not in present in ContentCoding. This is not good. The map should be LinkedHashMap<String, UnaryOperator<HttpEntity>>. This needs to be corrected first.

@arturobernalg
Copy link
Member Author

@arturobernalg I spotted another problem. The LinkedHashMap<ContentCoding, UnaryOperator<HttpEntity>> map used by HttpClientBuilder basically means one cannot plug-in 3rd party coders if they are not in present in ContentCoding. This is not good. The map should be LinkedHashMap<String, UnaryOperator<HttpEntity>>. This needs to be corrected first.

@ok2c I just made the change

@ok2c
Copy link
Member

ok2c commented Jul 16, 2025

@arturobernalg I would like to propose an alternative approach. Could you live with #678?

@ok2c
Copy link
Member

ok2c commented Jul 16, 2025

Superseded by #678

@ok2c ok2c closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants