Skip to content

Jep380SocketChannelAdapter: Connect in blocking mode #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschmitt merged 1 commit into from
Jul 5, 2025
+2 −1
Merged

Jep380SocketChannelAdapter: Connect in blocking mode #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions httpclient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,13 @@ private Jep380SocketChannelAdapter(final SocketChannel channel, final Jep380Sock
@Override
public void connect(final SocketAddress endpoint, final int timeout) throws IOException {
channel.connect(endpoint);
channel.configureBlocking(false);
}

@Override
public void connect(final SocketAddress endpoint) throws IOException {
channel.connect(endpoint);
channel.configureBlocking(false);
}

@Override
Expand Down
1 change: 0 additions & 1 deletion ...ient5/src/main/java/org/apache/hc/client5/http/socket/Jep380SocketChannelImplAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ final class Jep380SocketChannelImplAdapter extends SocketImpl {

public Jep380SocketChannelImplAdapter(final SocketChannel channel) throws IOException {
this.channel = channel;
channel.configureBlocking(false);
}

@Override
Expand Down