HTTPCLIENT-2380 – make DefaultAsyncClientConnectionOperator extensible #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
reviewed
Jul 3, 2025
| * release. Typical client code should use the high-level builders in | ||
| * {@code HttpAsyncClients} instead.</p> | ||
| * | ||
| * @since 5.6 |
Member
There was a problem hiding this comment.
@arturobernalg This change should also be cherry-picked to 5.5.x so I would just omit the version here or change it to @since 5.5. It is non-public class. We can change it in the stable branch as well.
…onnectionOperator and mark it @SInCE 5.6.
arturobernalg
force-pushed
the
HTTPASYNC-173
branch
from
0197da9 to
203c3d7
Compare
ok2c
approved these changes
Jul 3, 2025
Member
Author
Member
|
@arturobernalg The commit message is bad. The issue is wrong and there is version 5.6 in the message. Please correct the message and force-push the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes HTTPCLIENT-2380 by changing the constructor of
DefaultAsyncClientConnectionOperatorto protected, allowing external subclasses.