Skip to content

Conversation

@yhzdys
Copy link
Contributor

@yhzdys yhzdys commented Jul 2, 2025

Issue Link: HTTPCLIENT-2379

See Also: #663

@yhzdys yhzdys changed the title HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of s… HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of same PoolEntry Jul 2, 2025
@yhzdys yhzdys closed this Jul 2, 2025
@yhzdys yhzdys reopened this Jul 2, 2025
@yhzdys
Copy link
Contributor Author

yhzdys commented Jul 2, 2025

@arturobernalg
The PR I submitted is meant to reproduce the issue, so it fails the integration tests.
Should I take any further steps?

@arturobernalg
Copy link
Member

@arturobernalg The PR I submitted is meant to reproduce the issue, so it fails the integration tests. Should I take any further steps?

@yhzdys Please adjust the test so it merely reproduces the problem without breaking the build— by asserting the expected IllegalStateException

@yhzdys
Copy link
Contributor Author

yhzdys commented Jul 2, 2025

@arturobernalg The PR I submitted is meant to reproduce the issue, so it fails the integration tests. Should I take any further steps?

@yhzdys Please adjust the test so it merely reproduces the problem without breaking the build— by asserting the expected IllegalStateException

@arturobernalg Done. Test asserts the expected IllegalStateException.

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturobernalg arturobernalg merged commit 5c6c135 into apache:master Jul 3, 2025
10 checks passed
@ok2c
Copy link
Member

ok2c commented Jul 3, 2025

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

arturobernalg pushed a commit that referenced this pull request Jul 3, 2025
@arturobernalg
Copy link
Member

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

@ok2c done

@ok2c
Copy link
Member

ok2c commented Jul 6, 2025

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

@ok2c done

@arturobernalg I do not see the commit in 5.5.x. Could you please double-check and re-commit if needed?

@arturobernalg
Copy link
Member

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

@ok2c done

@arturobernalg I do not see the commit in 5.5.x. Could you please double-check and re-commit if needed?

@ok2c my bad. Should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants