Skip to content

HTTPCLIENT-1843: ContentCompressionExec improvements #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ok2c merged 1 commit into from
Jun 20, 2025
Merged

HTTPCLIENT-1843: ContentCompressionExec improvements #654

ok2c merged 1 commit into from
Jun 20, 2025

Conversation

@ok2c
Copy link
Member

@ok2c ok2c commented Jun 20, 2025

  • ContentCompressionExec constructor clean-up
  • Removed unused default method in InputStreamFactory

@ok2c
HTTPCLIENT-1843: ContentCompressionExec constructor clean-up; removed…
a88aae8 
… unused default method in InputStreamFactory
@ok2c ok2c requested a review from arturobernalg June 20, 2025 07:27
@ok2c
Copy link
Member Author

ok2c commented Jun 20, 2025

@arturobernalg I made some minor improvements to ContentCompressionExec. I also overlooked your changes had introduced a new default method to InputStreamFactory that was not used anywhere. I removed it. Please let me know if you disagree.

arturobernalg
arturobernalg approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c LGTM

@ok2c ok2c merged commit 20a4e9f into apache:master Jun 20, 2025
10 checks passed
@ok2c ok2c deleted the HTTPCLIENT-1843 branch July 2, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturobernalg arturobernalg arturobernalg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ok2c @arturobernalg