Adjust default behavior to match intended logic #646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Shouldn't these changes be validated through unit tests? |
Contributor
|
I don't understand the context here, nor the justification. Cookie management configuration shouldn't affect TLS configuration. |
Member
|
@arturobernalg Likewise, these changes do not look right to me. Cookie management and TLS hostname verification are completely unrelated. |
Member
Author
|
This PR was trying to fix an unintended side‐effect—calling disableCookieManagement() was disabling hostname checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default behavior is incorrect and intends to address it. This commit realigns the code so that the behavior now matches the expected default, per his feedback.